refactor: replace lazy_static with std::sync::LazyLock#198
Closed
39555 wants to merge 1 commit intoreubeno:mainfrom
Closed
refactor: replace lazy_static with std::sync::LazyLock#19839555 wants to merge 1 commit intoreubeno:mainfrom
lazy_static with std::sync::LazyLock#19839555 wants to merge 1 commit intoreubeno:mainfrom
Conversation
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Owner
|
Nice! Our current MSRV is 1.75, which was initially released about 10 months ago, and this would force us to move that forward. What would you see as the benefits of doing so now vs. later? More broadly, we need to establish a general procedure for when we upgrade the MSRV. I'll need to do some research to see what other projects do, but am very open to input here. |
Contributor
Author
|
We can do it later. There are no huge benefits |
Contributor
I found this: https://doc.rust-lang.org/cargo/reference/rust-version.html. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality of
lazy_staticnow in the core since 1.80 rust-lang/rust#121377