Conversation
Collaborator
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
- trim down things we dont need for otel, such as:
- listener
- attempt abandoned error
- remove endpoint hooks setters
- make sure to specify exact behavior of listeners
- move otel integration into core sdk
Comment on lines
+70
to
+73
| public setHooksProviders(hooks: HooksProvider[]): RestateEndpoint { | ||
| this.builder.setHooksProviders(hooks); | ||
| return this; | ||
| } |
Collaborator
There was a problem hiding this comment.
do we need this? given it's in service options, one should be able to set it from default service options
Comment on lines
+23
to
+26
| serviceName: string; | ||
| handlerName: string; | ||
| key?: string; | ||
| invocationId: string; |
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Contributor
Author
|
@slinkydeveloper I think your comments are addressed if you want to have another look |
Signed-off-by: Nik Nasr <nik@restate.dev>
Collaborator
|
@nikrooz for the tests, we wanna merge like this and you rebase on my pr later? or we merge my pr with the custom tests and you rebuild the tests on top? |
Contributor
Author
|
@slinkydeveloper I am open either way, but I think it would be faster to get it merge and get the feature out and then refactor the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interceptorandlistener: interceptors participate in execution, listeners are observational only.handlerinterceptors run on every attempt;runinterceptors run only when thectx.run()closure actually executes, not when the result is replayed from the journal.attemptEndis the normalized attempt outcome: success, retryableError, terminalError, or abandoned.try/catch/finallyflow.next()may reject withAttemptAbandonedErrorwhen an attempt is suspended or otherwise ended by the SDK; this is attempt-boundary control flow, not a user failure.