Allow configuring the PIA canary pods image in chart values#97
Allow configuring the PIA canary pods image in chart values#97LeBoucEtMistere wants to merge 1 commit intorestatedev:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA Arthur Depasse seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks a lot for contributing this improvement @LeBoucEtMistere. The changes look good to me. I will merge this PR once you have accepted the CLA.
|
Thanks, waiting for my company to review and approve the CLA, as this is a work-related contribution, will let you know when it's done. |
|
@tillrohrmann I see the fix was already merged as part of another PR, I think I can close this one then ? What's the ETA for a release of the new version with the change ? |
|
I think we are going to create a release of the restate-operator within the next few days. @lukebond please correct me if I am over promising things. |
|
yes i'll do one either today or tomorrow 👍 i was waiting for another feature to land, which now has |
|
@LeBoucEtMistere i didn't notice your PR for this i'm sorry! i went and reimplemented it having only seen the issue. thank you for your contribution! nevertheless the feature is on main now and i'll do a release today or tomorrow. |
Adresses issue #94
This allows configuring which container image is used for PIA canary pods instead of relying on a hardcoded value. This is controlled by helm chart values.