fix: poll every 10s when old deployments are actively draining#112
Merged
lukebond merged 1 commit intorestatedev:mainfrom Mar 27, 2026
Merged
fix: poll every 10s when old deployments are actively draining#112lukebond merged 1 commit intorestatedev:mainfrom
lukebond merged 1 commit intorestatedev:mainfrom
Conversation
mt-bt
force-pushed
the
fix/drain-poll-interval
branch
from
ddc42c3 to
e661222
Compare
When old deployments have active invocations (draining), the cleanup functions skip them without setting next_removal, causing the controller to fall back to the hardcoded 5-minute requeue. This means even with drainDelaySeconds: 0, cleanup takes ~5 minutes. Poll every 10s when active drains are detected, so the operator notices drain completion promptly.
mt-bt
changed the title
mt-bt
force-pushed
the
fix/drain-poll-interval
branch
from
e661222 to
3338559
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When old deployments have active invocations (draining),
cleanup_old_replicasets/cleanup_old_configurationsskip them without settingnext_removal, so the controller falls back to the hardcoded 5-minute requeue. This means even withdrainDelaySeconds: 0, cleanup takes ~5 minutes.This PR polls every 10 seconds when active drains are detected, so the operator notices drain completion promptly instead of always waiting 5 minutes.
Open to discussion on the 10s interval - happy to make it configurable or use a different value if there's a preference.
Follow-up to #96.