Fix exception record field regression#8319
Merged
fhammerschmidt merged 2 commits intorescript-lang:masterfrom Mar 29, 2026
Merged
Fix exception record field regression#8319fhammerschmidt merged 2 commits intorescript-lang:masterfrom
fhammerschmidt merged 2 commits intorescript-lang:masterfrom
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cristianoc
approved these changes
Mar 29, 2026
| let args, ret_type, kind = | ||
| match sext.pext_kind with | ||
| | Pext_decl (sargs, sret_type) -> | ||
| let sargs = rewrite_optional_inline_record_fields sargs in |
Collaborator
There was a problem hiding this comment.
so this was missing -- legit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes https://forum.rescript-lang.org/t/exceptions-with-optional-fields-are-failing-in-rescript-v12/7162
cc @mvaled