-
Notifications
You must be signed in to change notification settings - Fork 34
Edit per license event filter details #3921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+85
−37
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,7 +123,7 @@ As a Development Leader, I want to be notified when a paid customer pulls releas | |
|
|
||
| ### Revenue operations: First software pull for revenue recognition | ||
|
|
||
| As a Revenue Operations Manager, receive a notification the first time a paid customer retrieves software to record the exact revenue recognition timestamp. | ||
| As a Revenue Operations Manager, I want to receive a notification the first time a paid customer pulls software so that I can record the exact revenue recognition timestamp. | ||
paigecalvert marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - **Event Type:** Release Asset Downloaded | ||
| - **Configuration:** | ||
|
|
@@ -132,10 +132,6 @@ As a Revenue Operations Manager, receive a notification the first time a paid cu | |
| - Filter - Pull Type: "First Pull for Selected License Type" | ||
| - **Delivery Method:** Webhook to your customer relationship management system | ||
|
|
||
| :::note | ||
| Use "First Pull for Selected License Type" rather than "First Pull Only" if customers may start on a trial before converting to a paid license. "First Pull Only" tracks the first-ever pull regardless of license type. If a customer pulls on a trial license first, the notification will not fire again after they convert to paid. "First Pull for Selected License Type" tracks milestones per license type. The notification fires the first time the customer pulls software with a paid license, even if they previously pulled on a trial. | ||
| ::: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ^ figured this was already covered well in the reference doc for event types and filters |
||
|
|
||
| ### Support engineer: Unhealthy instance alert | ||
|
|
||
| As a Support Engineer, you want to be notified when a customer instance has been in an unhealthy state for an extended period so that you can proactively reach out. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true for Enterprise Portal Access Granted per-license type events as well?
The original note for the Assets Downloaded event type (https://github.com/replicatedhq/replicated-docs/pull/3916/changes#diff-29ef7f7ee6ea45aa9c4b78b07e0a25acf8845674d0aed4d9e509c13d5f839629R198) used the phrase "per-license-type milestones", and I wasn't sure if that broad term was intended to cover the per license type filters for both Assets Downloaded and Enterprise Portal Access Granted events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes to both. PR vandoor#9313 (merged March 27, 2026) introduced per-license-type milestone tracking for both events in the same change. It created two new tables:
software_pull_milestones (for Release Assets Downloaded)
enterprise_portal_access_milestones (for EP Access Granted)
Both tables are forward-only (INSERT IGNORE, write-once). The original "per-license-type milestones" phrasing was intentionally broad because it covered both. So the note "First Access for Selected License Type only tracks Enterprise Portal access events that occur after March 27, 2026" is correct. The March 27 date is the merge/deploy date of #9313, and the same cutoff applies to both event types.