Conversation
There was a problem hiding this comment.
Pull request overview
Adds support in relay_rpc for a new JSON-RPC method wc_proposeSessionV2 intended to propose a session without the caller providing a pairing topic, and to return the pairing topic in the response.
Changes:
- Generalizes
ProposeSessionto be generic overpairing_topicand introducesProposeSessionV2+ProposeSessionV2Response. - Adds
Params::ProposeSessionV2withwc_proposeSessionV2serde rename and wires it into request validation. - Adds a helper intended to convert a V2 request into a V1
ProposeSessionby injecting a pairing topic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
3 tasks
|
@xDarksome I've opened a new pull request, #105, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: xDarksome <22872975+xDarksome@users.noreply.github.com>
…rust into feat/propose-session-v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new
wc_proposeSessionV2method that returns pairing topic id instead of requiring it to be provided.How Has This Been Tested?
Relay staging
Due Diligence