fix(contractor-onboarding) - fix mark review#796
Open
gabrielseco wants to merge 7 commits intomainfrom
Open
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (310 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready! ✅ Preview Built with commit 27c22c3. |
Contributor
|
Deploy preview for remote-flows-example-app ready! ✅ Preview Built with commit 27c22c3. |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk: small state-management change confined to the contractor onboarding flow plus accompanying type updates and a regression test around contract preview/signature visibility.
Overview
Fixes contract-review state synchronization by routing
markContractAsReviewedthrough a newoptions.onContractReviewedcallback and havingContractorOnboardingFlowupdate the underlyingreact-hook-formvalue (review_completed) via a storedsetValueref.Refactors onboarding option types to introduce
ContractorOnboardingFlowOptionsandContractorOnboardingHookOptions(addsonContractReviewed), and updates tests with a new regression case ensuring the signature input remains visible while typing after marking the contract as reviewed (plus a stricterReviewbutton selector).Written by Cursor Bugbot for commit 27c22c3. This will update automatically on new commits. Configure here.