Skip to content

fix(contractor-onboarding) - fix mark review#796

Open
gabrielseco wants to merge 7 commits intomainfrom
fix-mark-review-contract
Open

fix(contractor-onboarding) - fix mark review#796
gabrielseco wants to merge 7 commits intomainfrom
fix-mark-review-contract

Conversation

@gabrielseco
Copy link
Collaborator

@gabrielseco gabrielseco commented Mar 16, 2026

Note

Low Risk
Low risk: small state-management change confined to the contractor onboarding flow plus accompanying type updates and a regression test around contract preview/signature visibility.

Overview
Fixes contract-review state synchronization by routing markContractAsReviewed through a new options.onContractReviewed callback and having ContractorOnboardingFlow update the underlying react-hook-form value (review_completed) via a stored setValue ref.

Refactors onboarding option types to introduce ContractorOnboardingFlowOptions and ContractorOnboardingHookOptions (adds onContractReviewed), and updates tests with a new regression case ensuring the signature input remains visible while typing after marking the contract as reviewed (plus a stricter Review button selector).

Written by Cursor Bugbot for commit 27c22c3. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 199.82 kB 199.77 kB +47 B (+0.0%) 🔴
Total (raw) 528.54 kB 528.36 kB +185 B (+0.0%) 🔴
CSS (gzip) 19.32 kB 19.32 kB 0 B (0%) 🟢
CSS (raw) 100 kB 100 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 199.82 kB / 200 kB (99.9%)
  • ✅ Total raw: 528.54 kB / 550 kB (96.1%)
  • ✅ CSS gzipped: 19.32 kB / 25 kB (77.3%)

Largest Files (Top 5)

  1. chunk-7EONM7HL.js - 12.44 kB (0 B (0%))
  2. styles.css - 9.66 kB (0 B (0%))
  3. index.css - 9.66 kB (0 B (0%))
  4. index.js - 6.04 kB (-8 B (-0.1%))
  5. chunk-WQ4H5V7U.js - 5.77 kB (0 B (0%))
View All Files (310 total)
File Size (gzip) Change
chunk-7EONM7HL.js 12.44 kB 0 B (0%)
styles.css 9.66 kB 0 B (0%)
index.css 9.66 kB 0 B (0%)
index.js 6.04 kB -8 B (-0.1%)
chunk-WQ4H5V7U.js 5.77 kB 0 B (0%)
chunk-I5J63OOE.js 4.24 kB new
chunk-JIW2JK7J.js 4.06 kB 0 B (0%)
chunk-4OJ4TAXO.js 3.36 kB 0 B (0%)
chunk-T7O3YYOG.js 3.29 kB 0 B (0%)
chunk-EMP4ZIVB.js 3.21 kB 0 B (0%)

✅ Bundle size check passed

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

Deploy preview for remote-flows ready!

✅ Preview
https://remote-flows-2yvbwy5td-remotecom.vercel.app

Built with commit 27c22c3.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

Deploy preview for remote-flows-example-app ready!

✅ Preview
https://remote-flows-example-pgwenra5e-remotecom.vercel.app

Built with commit 27c22c3.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2026

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 89.44% 89.40% +0.04% 🟢
Statements 89.12% 89.08% +0.04% 🟢
Functions 86.86% 86.75% +0.12% 🟢
Branches 79.28% 79.30% -0.02% 🔴

Detailed Breakdown

Lines Coverage
  • Covered: 3413 / 3816
  • Coverage: 89.44%
  • Change: +0.04% (6 lines)
Statements Coverage
  • Covered: 3474 / 3898
  • Coverage: 89.12%
  • Change: +0.04% (6 statements)
Functions Coverage
  • Covered: 952 / 1096
  • Coverage: 86.86%
  • Change: +0.12% (3 functions)
Branches Coverage
  • Covered: 2131 / 2688
  • Coverage: 79.28%
  • Change: -0.02% (1 branches)

✅ Coverage check passed

@gabrielseco gabrielseco marked this pull request as ready for review March 16, 2026 11:24
@gabrielseco gabrielseco self-assigned this Mar 16, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant