This repository was archived by the owner on May 8, 2023. It is now read-only.
container contents events completed and will send container data to private nats#140
Open
Ultraporing wants to merge 1 commit intoregner:masterfrom
Open
container contents events completed and will send container data to private nats#140Ultraporing wants to merge 1 commit intoregner:masterfrom
Ultraporing wants to merge 1 commit intoregner:masterfrom
Conversation
Ultraporing
force-pushed
the
container_contents
branch
2 times, most recently
from
359bfae to
ab80825
Compare
Contributor
|
Nice! Could we try adding the map parameter 2 on event 42? This looks like the uuid of either the owner or the "opener". I can check it in the morning |
regner
reviewed
Sep 13, 2017
client/event_container_opening.go
Outdated
| log.Debug("Got container opening event...") | ||
|
|
||
| if state.LocationId == 0 { | ||
| log.Warn("The players location has not yet been set. Please transition zones so the location can be identified.") |
Owner
There was a problem hiding this comment.
Assuming both these take the same type of parameter can you define this once as msg and pass that to log and notification?
Ultraporing
force-pushed
the
container_contents
branch
from
d740546 to
16380d1
Compare
Contributor
Author
|
It could also be the GUID of the object. so you know what container. |
Ultraporing
force-pushed
the
container_contents
branch
3 times, most recently
from
5277f5b to
8e0d75c
Compare
Contributor
Author
|
Added event 75 (generic container), and we send now the ContainerType "Bank" || "Generic" and the ContainerGUID to Nats too. |
Ultraporing
force-pushed
the
container_contents
branch
from
c8cc6fd to
50d5de7
Compare
Owner
|
Looking good, any other comments or requests before I merge? |
Contributor
Author
|
Not from me, all good. |
Contributor
Author
|
Currently not up to date with the new location update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @oxisto for helping me to figure out the packets.
Closes #119