Dockerfile refactored for smaller image layers and faster builds#17
Open
ansonkao wants to merge 1 commit intoredotvideo:mainfrom
Open
Dockerfile refactored for smaller image layers and faster builds#17ansonkao wants to merge 1 commit intoredotvideo:mainfrom
ansonkao wants to merge 1 commit intoredotvideo:mainfrom
Conversation
Author
|
With this change, only 2 layers need to be pushed with a scene code change as opposed to 4, and each layer is smaller |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thing that changes the most are the scene code which is quite small, so break the npm package installation out, then reorder things a bit.