feat: add typed GCRA command support and functional tests#2094
Open
PavelPashov wants to merge 1 commit intoredis:mainfrom
Open
feat: add typed GCRA command support and functional tests#2094PavelPashov wants to merge 1 commit intoredis:mainfrom
PavelPashov wants to merge 1 commit intoredis:mainfrom
Conversation
PavelPashov
force-pushed
the
feat/add-gcra
branch
from
11d8ae3 to
84eeed7
Compare
nkaradzhov
requested changes
Apr 7, 2026
| gcra( | ||
| key: RedisKey, | ||
| maxBurst: number | string, | ||
| requestsPerPeriod: number | string, |
| requestsPerPeriod: number | string, | ||
| period: number | string, | ||
| countToken: "NUM_REQUESTS", | ||
| count: number | string, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: changes are limited to adding new TypeScript command typings, a small dependency bump, and test-suite updates gated by Redis server version.
Overview
Adds typed support for Redis
GCRArate-limiting command (includingNUM_REQUESTSvariant) toRedisCommanderand bumps@ioredis/commandsto1.6.0.Introduces a shared
isRedisVersionLowerThanhelper and updates functional tests to run conditionally based on server version (unskippinghgetdel/hgetex/hsetex/xdelexand enablingxtrimpolicy tests), plus new functional coverage forgcra.Reviewed by Cursor Bugbot for commit 84eeed7. Bugbot is set up for automated code reviews on this repo. Configure here.