fix(test): fully resolve spub/ssub auto-resubscription race condition#2093
Open
rit3sh-x wants to merge 2 commits intoredis:mainfrom
Open
fix(test): fully resolve spub/ssub auto-resubscription
race condition#2093rit3sh-x wants to merge 2 commits intoredis:mainfrom
rit3sh-x wants to merge 2 commits intoredis:mainfrom
Conversation
Follow-up to redis#2092. Await initial ssubscribe calls and poll for stub.callCount before asserting, so the test is stable under load.
Contributor
|
@rit3sh-x thanks, I'll take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
Low Risk
Low risk: test-only changes that make the auto-resubscribe assertions deterministic by removing timing races around
ssubscribeand reconnect.Overview
Makes the
spub/ssubauto-resubscription functional test deterministic by awaiting initialssubscribecalls before disconnecting and by polling thessubscribestub until all expected resubscribe calls have occurred (instead of assumingping()is a sufficient barrier).Reviewed by Cursor Bugbot for commit 58ee73b. Bugbot is set up for automated code reviews on this repo. Configure here.