RI-000: Add column sorting for browser key list (list view)#5690
Merged
pawelangelow merged 9 commits intomainfrom Mar 24, 2026
Merged
RI-000: Add column sorting for browser key list (list view)#5690pawelangelow merged 9 commits intomainfrom
pawelangelow merged 9 commits intomainfrom
Conversation
af15352 to
27eeea2
Compare
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
redisinsight/ui/src/pages/browser/components/key-list/KeyList.types.ts
Outdated
Show resolved
Hide resolved
dantovska
previously approved these changes
Mar 24, 2026
valkirilov
previously approved these changes
Mar 24, 2026
Contributor
Code Coverage - Frontend unit tests
Test suite run success6530 tests passing in 773 suites. Report generated by 🧪jest coverage report action from 6eece64 |
34d2508 to
3529e55
Compare
valkirilov
previously approved these changes
Mar 24, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
redisinsight/ui/src/pages/browser/components/browser-left-panel/BrowserLeftPanelLegacy.tsx
Outdated
Show resolved
Hide resolved
valkirilov
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Adds client-side column sorting to the browser key list. Users can now
sort keys by Name, TTL, or Size in ascending or descending order
directly from the Columns popover.
Credits to #5673 (@burryfun) for the original proposal and implementation. ❤️
We decided to take a different UX approach - sorting controls live inside the existing Columns popover rather than in a dedicated sort bar. The goal is to provide the same functionality with less UI space consumption and lower complexity, while fully supporting all use cases of the component.
Preview
Note
Medium Risk
Moderate risk because it changes key-list rendering order and rewrites metadata-fetch application logic (including request cancellation and scroll resets), which could impact list integrity or performance in edge cases.
Overview
Adds client-side sorting for the Browser key list (List view) via the existing Columns popover, letting users sort by Key, TTL, or Size (ASC/DESC) and clearing sort automatically when a sorted column is hidden.
Updates
KeyListto accept asortedColumn, apply stable ordering (treating missing metadata andttl=-1as “no value” so they sort last), and re-run sorting as metadata arrives.Refactors metadata fetching to update rows by reference instead of positional splicing to prevent corrupting the list when only a subset of visible rows fetches metadata, and adds coverage for sorting behavior + async metadata edge cases.
Written by Cursor Bugbot for commit 6eece64. This will update automatically on new commits. Configure here.