RI-8038 [E2E] 7.2 Settings -> Privacy Settings#5592
Merged
valkirilov merged 4 commits intomainfrom Mar 25, 2026
Merged
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
redisinsight/ui/src/pages/browser/components/redisearch-key-list/RediSearchIndexesList.tsx
Show resolved
Hide resolved
8a34c78 to
ffc6852
Compare
KrumTy
previously approved these changes
Mar 9, 2026
valkirilov
reviewed
Mar 10, 2026
| @@ -666,9 +666,9 @@ The test plan is organized by feature area. Tests are grouped for parallel execu | |||
| ### 7.2 Privacy Settings | |||
Member
tests/e2e-playwright/tests/main/settings/privacy-settings/privacy-settings.spec.ts
Outdated
Show resolved
Hide resolved
References: #RI-8038 Made-with: Cursor
…lity Replaced the visibility check for the privacy button with a check for the privacy section header to improve test accuracy and align with recent refactoring in the SettingsPage class.
Updated the privacy settings tests to verify the display of privacy settings, including the usage data switch and privacy policy link. Added tests to confirm telemetry behavior when toggling usage data on and off, ensuring no telemetry is emitted when usage data is disabled. Enhanced the SettingsPage class with methods for checking usage data status and intercepting telemetry requests.
8258ebb to
e6d5c09
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
dantovska
previously approved these changes
Mar 24, 2026
pawelangelow
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Add Playwright E2E tests for the Privacy Settings section (7.2) of the Settings page.
Tests verify that the privacy section expands correctly, the usage data switch is displayed, and the privacy policy link is visible with the correct target attribute.
Testing
Run:
npx playwright test tests/main/settings/privacy-settingsCloses #RI-8038
Made with Cursor
Note
Low Risk
Low risk: changes are confined to Playwright E2E tests and test-plan documentation, with no production code impact. Main risk is potential test flakiness from network interception and timing around the settings
PATCH /api/settingsresponse.Overview
Adds a new Playwright spec for Settings → Privacy that verifies the section renders correctly (usage data switch and privacy policy link) and that toggling usage data suppresses or enables telemetry requests as expected.
Extends the
SettingsPagepage object with helpers to toggle usage-data while waiting for the settingsPATCH /api/settings, and to intercept**/analytics/send-*requests for assertions. UpdatesTEST_PLAN.mdto mark the new Privacy/telemetry cases as implemented.Written by Cursor Bugbot for commit 802d9a6. This will update automatically on new commits. Configure here.