Skip to content

RI-8038 [E2E] 7.2 Settings -> Privacy Settings#5592

Merged
valkirilov merged 4 commits intomainfrom
e2e/RI-8038/privacy-settings
Mar 25, 2026
Merged

RI-8038 [E2E] 7.2 Settings -> Privacy Settings#5592
valkirilov merged 4 commits intomainfrom
e2e/RI-8038/privacy-settings

Conversation

@pd-redis
Copy link
Contributor

@pd-redis pd-redis commented Mar 4, 2026

What

Add Playwright E2E tests for the Privacy Settings section (7.2) of the Settings page.

Tests verify that the privacy section expands correctly, the usage data switch is displayed, and the privacy policy link is visible with the correct target attribute.

Testing

Run: npx playwright test tests/main/settings/privacy-settings


Closes #RI-8038

Made with Cursor


Note

Low Risk
Low risk: changes are confined to Playwright E2E tests and test-plan documentation, with no production code impact. Main risk is potential test flakiness from network interception and timing around the settings PATCH /api/settings response.

Overview
Adds a new Playwright spec for Settings → Privacy that verifies the section renders correctly (usage data switch and privacy policy link) and that toggling usage data suppresses or enables telemetry requests as expected.

Extends the SettingsPage page object with helpers to toggle usage-data while waiting for the settings PATCH /api/settings, and to intercept **/analytics/send-* requests for assertions. Updates TEST_PLAN.md to mark the new Privacy/telemetry cases as implemented.

Written by Cursor Bugbot for commit 802d9a6. This will update automatically on new commits. Configure here.

@jit-ci
Copy link

jit-ci bot commented Mar 4, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@pd-redis pd-redis force-pushed the e2e/RI-8038/privacy-settings branch from 8a34c78 to ffc6852 Compare March 5, 2026 08:55
KrumTy
KrumTy previously approved these changes Mar 9, 2026
@KrumTy KrumTy dismissed their stale review March 9, 2026 13:21

to be re-reviewed once tests pass

@@ -666,9 +666,9 @@ The test plan is organized by feature area. Tests are grouped for parallel execu
### 7.2 Privacy Settings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being in the context of an e2e test, does it make sense to actually verify whether we send (or don't) telemetry data, once we toggle the Usage data switch?

Like, a simple network interceptor, just to verify whether we emit send-page and send-event 🤔

Image

@pd-redis pd-redis requested review from KrumTy and valkirilov March 16, 2026 07:34
pd-redis and others added 3 commits March 24, 2026 13:46
References: #RI-8038
Made-with: Cursor
…lity

Replaced the visibility check for the privacy button with a check for the privacy section header to improve test accuracy and align with recent refactoring in the SettingsPage class.
Updated the privacy settings tests to verify the display of privacy settings, including the usage data switch and privacy policy link. Added tests to confirm telemetry behavior when toggling usage data on and off, ensuring no telemetry is emitted when usage data is disabled. Enhanced the SettingsPage class with methods for checking usage data status and intercepting telemetry requests.
@valkirilov valkirilov force-pushed the e2e/RI-8038/privacy-settings branch from 8258ebb to e6d5c09 Compare March 24, 2026 12:23
@valkirilov valkirilov requested a review from a team as a code owner March 24, 2026 12:23
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

dantovska
dantovska previously approved these changes Mar 24, 2026
@valkirilov valkirilov merged commit 997bbe2 into main Mar 25, 2026
5 checks passed
@valkirilov valkirilov deleted the e2e/RI-8038/privacy-settings branch March 25, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants