RI-7186 validate job name separately#4804
Merged
ArtemHoruzhenko merged 2 commits intofe/feature/RI-7039-replace-euifrom Aug 7, 2025
Merged
RI-7186 validate job name separately#4804ArtemHoruzhenko merged 2 commits intofe/feature/RI-7039-replace-euifrom
ArtemHoruzhenko merged 2 commits intofe/feature/RI-7039-replace-euifrom
Conversation
KIvanow
previously approved these changes
Aug 5, 2025
ArtemHoruzhenko
force-pushed
the
fe/feature/RI-7186-jobs-validation-fix
branch
from
15ccce0 to
41759a7
Compare
Contributor
Code Coverage - Frontend unit tests
Test suite run success4867 tests passing in 635 suites. Report generated by 🧪jest coverage report action from 2ac3f9f |
ArtemHoruzhenko
requested review from
KrumTy,
dantovska,
pawelangelow and
pd-redis
as code owners
KrumTy
previously approved these changes
Aug 6, 2025
Base automatically changed from
fe/feature/RI-7217-allow-deplot-invalid-rdi-pipeline
to
fe/feature/RI-7039-replace-eui
August 7, 2025 08:37
ArtemHoruzhenko
dismissed stale reviews from KrumTy and KIvanow
The base branch was changed.
ArtemHoruzhenko
force-pushed
the
fe/feature/RI-7186-jobs-validation-fix
branch
from
2ac3f9f to
b2c2a62
Compare
KIvanow
approved these changes
Aug 7, 2025
ArtemHoruzhenko
merged commit 2e5d9ee
into
fe/feature/RI-7039-replace-eui
1 check passed
ArtemHoruzhenko
added a commit
that referenced
this pull request
Aug 7, 2025
* RI-7186 validate job name separately * RI-7186 add tests (cherry picked from commit 2e5d9ee)
ArtemHoruzhenko
added a commit
that referenced
this pull request
Aug 7, 2025
* RI-7217 allow to deplot rdi pipeline with validation errors (#4796) * RI-7217 allow to deplot rdi pipeline with validation errors * align text and icon * RI-7217 move errors list to a separate component and add tests * RI-7217 fix PR comments * RI-7217 fix test --------- Co-authored-by: pd-redis <petar.dzhambazov@redis.com> (cherry picked from commit a3a28b5) * RI-7186 validate job name separately (#4804) * RI-7186 validate job name separately * RI-7186 add tests (cherry picked from commit 2e5d9ee) --------- Co-authored-by: pd-redis <petar.dzhambazov@redis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omit job validation schema from jobs schema and process it separately. This will fix behavior when name became mandatory in the root of jobs yaml.
Handle job name validation the same way as job body on UI