Remove assisted-service pod before recreation to pick up config changes#787
Draft
mcornea wants to merge 1 commit intoredhat-performance:mainfrom
Draft
Conversation
When re-running setup-bastion.yml with different network configuration (e.g., switching from IPv4 to IPv6), the assisted-service containers kept running with the old environment because the pod restart + container state:started pattern did not force container recreation with the updated onprem-environment file. Replace the create+restart pattern with an explicit remove+create cycle. This ensures containers are always created fresh with the current configuration, fixing disconnected IPv6 deployments after an IPv4 deploy. Fixes redhat-performance#765 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This was referenced Mar 20, 2026
Collaborator
Author
|
/test deploy-sno |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When re-running
setup-bastion.ymlwith different network configuration (e.g., switching from IPv4 to IPv6), the assisted-service containers kept the old environment. The pod restart + containerstate: startedpattern did not force container recreation with the updatedonprem-environmentfile.This replaces the create+restart pattern with an explicit remove+create cycle, ensuring containers are always created fresh with the current configuration.
Fixes #765
Test Plan
deploy-sno— standard IPv4 deployment (regression test)deploy-sno-reconfig-ipv6— IPv4 deploy followed by IPv6 redeploy on same bastion (requires openshift/release companion PR)Changes
state: started+state: restartedtwo-step pod creationstate: absenttask before pod creation to ensure old containers are fully removedonprem-environmentconfigCross-Repo
This PR requires a companion PR in
openshift/releaseto add thedeploy-sno-reconfig-ipv6test job with aREDEPLOY_IPV6env var that exercises the IPv4→IPv6 reconfiguration path.