-
Notifications
You must be signed in to change notification settings - Fork 94
chore(header): upgrade backstage, nfs app & app-legacy setup #2608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rohitkrai03
wants to merge
1
commit into
redhat-developer:main
Choose a base branch
from
rohitkrai03:nfs-header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,563
−6,170
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| playwright.config.ts | ||
| e2e-tests/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,3 +53,6 @@ site | |
|
|
||
| # E2E test reports | ||
| e2e-test-report/ | ||
| **/e2e-test-report*/ | ||
| **/test-results/ | ||
| **/playwright-report/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "version": "1.45.2" | ||
| "version": "1.49.2" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| public |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| { | ||
| "name": "app-legacy", | ||
| "version": "0.0.0", | ||
| "private": true, | ||
| "bundled": true, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/redhat-developer/rhdh-plugins", | ||
| "directory": "workspaces/global-header/packages/app-legacy" | ||
| }, | ||
| "backstage": { | ||
| "role": "frontend" | ||
| }, | ||
| "scripts": { | ||
| "start": "backstage-cli package start", | ||
| "build": "backstage-cli package build", | ||
| "clean": "backstage-cli package clean", | ||
| "test": "backstage-cli package test", | ||
| "lint": "backstage-cli package lint" | ||
| }, | ||
| "dependencies": { | ||
| "@backstage/app-defaults": "^1.7.6", | ||
| "@backstage/catalog-model": "^1.7.7", | ||
| "@backstage/cli": "^0.36.0", | ||
| "@backstage/core-app-api": "^1.19.6", | ||
| "@backstage/core-components": "^0.18.8", | ||
| "@backstage/core-plugin-api": "^1.12.4", | ||
| "@backstage/integration-react": "^1.2.16", | ||
| "@backstage/plugin-api-docs": "^0.13.5", | ||
| "@backstage/plugin-catalog": "^2.0.1", | ||
| "@backstage/plugin-catalog-common": "^1.1.8", | ||
| "@backstage/plugin-catalog-graph": "^0.6.0", | ||
| "@backstage/plugin-catalog-import": "^0.13.11", | ||
| "@backstage/plugin-catalog-react": "^2.1.0", | ||
| "@backstage/plugin-kubernetes": "^0.12.17", | ||
| "@backstage/plugin-notifications": "^0.5.15", | ||
| "@backstage/plugin-org": "^0.7.0", | ||
| "@backstage/plugin-permission-react": "^0.4.41", | ||
| "@backstage/plugin-scaffolder": "^1.36.1", | ||
| "@backstage/plugin-search": "^1.7.0", | ||
| "@backstage/plugin-search-react": "^1.11.0", | ||
| "@backstage/plugin-signals": "^0.0.29", | ||
| "@backstage/plugin-techdocs": "^1.17.2", | ||
| "@backstage/plugin-techdocs-module-addons-contrib": "^1.1.34", | ||
| "@backstage/plugin-techdocs-react": "^1.3.9", | ||
| "@backstage/plugin-user-settings": "^0.9.1", | ||
| "@backstage/theme": "^0.7.2", | ||
| "@backstage/ui": "^0.13.1", | ||
| "@material-ui/core": "^4.12.2", | ||
| "@material-ui/icons": "^4.9.1", | ||
| "@mui/icons-material": "5.18.0", | ||
| "@mui/material": "5.18.0", | ||
| "@red-hat-developer-hub/backstage-plugin-global-header": "workspace:^", | ||
| "@red-hat-developer-hub/backstage-plugin-global-header-test": "workspace:^", | ||
| "@red-hat-developer-hub/backstage-plugin-theme": "^0.12.0", | ||
| "react": "^18.0.2", | ||
| "react-dom": "^18.0.2", | ||
| "react-router": "^6.3.0", | ||
| "react-router-dom": "^6.3.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@axe-core/playwright": "^4.10.0", | ||
| "@backstage/test-utils": "^1.7.16", | ||
| "@playwright/test": "1.58.2", | ||
| "@testing-library/dom": "^9.0.0", | ||
| "@testing-library/jest-dom": "^6.0.0", | ||
| "@testing-library/react": "^14.0.0", | ||
| "@testing-library/user-event": "^14.0.0", | ||
| "@types/react-dom": "*", | ||
| "cross-env": "^7.0.0" | ||
| }, | ||
| "browserslist": { | ||
| "production": [ | ||
| ">0.2%", | ||
| "not dead", | ||
| "not op_mini all" | ||
| ], | ||
| "development": [ | ||
| "last 1 chrome version", | ||
| "last 1 firefox version", | ||
| "last 1 safari version" | ||
| ] | ||
| }, | ||
| "files": [ | ||
| "dist" | ||
| ] | ||
| } |
Binary file added
BIN
+13.3 KB
workspaces/global-header/packages/app-legacy/public/android-chrome-192x192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+12.3 KB
workspaces/global-header/packages/app-legacy/public/apple-touch-icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+883 Bytes
workspaces/global-header/packages/app-legacy/public/favicon-16x16.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.65 KB
workspaces/global-header/packages/app-legacy/public/favicon-32x32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
60 changes: 60 additions & 0 deletions
60
workspaces/global-header/packages/app-legacy/public/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1" /> | ||
| <meta name="theme-color" content="#000000" /> | ||
| <meta | ||
| name="description" | ||
| content="Backstage is an open source framework for building developer portals" | ||
| /> | ||
| <!-- | ||
| manifest.json provides metadata used when your web app is installed on a | ||
| user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/ | ||
| --> | ||
| <link | ||
| rel="manifest" | ||
| href="<%= publicPath %>/manifest.json" | ||
| crossorigin="use-credentials" | ||
| /> | ||
| <link rel="icon" href="<%= publicPath %>/favicon.ico" /> | ||
| <link rel="shortcut icon" href="<%= publicPath %>/favicon.ico" /> | ||
| <link | ||
| rel="apple-touch-icon" | ||
| sizes="180x180" | ||
| href="<%= publicPath %>/apple-touch-icon.png" | ||
| /> | ||
| <link | ||
| rel="icon" | ||
| type="image/png" | ||
| sizes="32x32" | ||
| href="<%= publicPath %>/favicon-32x32.png" | ||
| /> | ||
| <link | ||
| rel="icon" | ||
| type="image/png" | ||
| sizes="16x16" | ||
| href="<%= publicPath %>/favicon-16x16.png" | ||
| /> | ||
| <link | ||
| rel="mask-icon" | ||
| href="<%= publicPath %>/safari-pinned-tab.svg" | ||
| color="#5bbad5" | ||
| /> | ||
| <title><%= config.getOptionalString('app.title') ?? 'Backstage' %></title> | ||
| </head> | ||
| <body> | ||
| <noscript>You need to enable JavaScript to run this app.</noscript> | ||
| <div id="root"></div> | ||
| <!-- | ||
| This HTML file is a template. | ||
| If you open it directly in the browser, you will see an empty page. | ||
|
|
||
| You can add webfonts, meta tags, or analytics to this file. | ||
| The build step will place the bundled scripts into the <body> tag. | ||
|
|
||
| To begin the development, run `yarn start`. | ||
| To create a production bundle, use `yarn build`. | ||
| --> | ||
| </body> | ||
| </html> |
15 changes: 15 additions & 0 deletions
15
workspaces/global-header/packages/app-legacy/public/manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "short_name": "Backstage", | ||
| "name": "Backstage", | ||
| "icons": [ | ||
| { | ||
| "src": "favicon.ico", | ||
| "sizes": "48x48", | ||
| "type": "image/png" | ||
| } | ||
| ], | ||
| "start_url": "./index.html", | ||
| "display": "standalone", | ||
| "theme_color": "#000000", | ||
| "background_color": "#ffffff" | ||
| } |
2 changes: 2 additions & 0 deletions
2
workspaces/global-header/packages/app-legacy/public/robots.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # https://www.robotstxt.org/robotstxt.html | ||
| User-agent: * |
1 change: 1 addition & 0 deletions
1
workspaces/global-header/packages/app-legacy/public/safari-pinned-tab.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 44 additions & 0 deletions
44
workspaces/global-header/packages/app-legacy/src/App.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /* | ||
| * Copyright Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { render, waitFor } from '@testing-library/react'; | ||
| import App from './App'; | ||
|
|
||
| describe('App', () => { | ||
| it('should render', async () => { | ||
| process.env = { | ||
| NODE_ENV: 'test', | ||
| APP_CONFIG: [ | ||
| { | ||
| data: { | ||
| app: { title: 'Test' }, | ||
| backend: { baseUrl: 'http://localhost:7007' }, | ||
| techdocs: { | ||
| storageUrl: 'http://localhost:7007/api/techdocs/static/docs', | ||
| }, | ||
| }, | ||
| context: 'test', | ||
| }, | ||
| ] as any, | ||
| }; | ||
|
|
||
| const rendered = render(<App />); | ||
|
|
||
| await waitFor(() => { | ||
| expect(rendered.baseElement).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.