[#536] Redeploy StoryFactory with J-curve + real PLOT#66
Conversation
- Update PLOT token address to 0x4F567DACBF9D15A6acBe4A47FC2Ade0719Fb63C4 - Replace algorithmic exponential curve with exact 500 hardcoded step prices from story-token-curve.txt (J-curve: 0.001 → 1.8882421 PLOT) - Rename generateCurve() → getCurve() - Update DumpCurve.s.sol and tests for new function name - Update test assertions for new J-curve values (hashes, spot-checks) - All 10 DeployBase tests pass Fixes realproject7/plotlink#536 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
APPROVE — thorough contract review. PLOT token address correct, 500 hardcoded J-curve prices verified (0.001 → 1.8882421 PLOT), classic J-curve shape confirmed (flat early, steep at end). Tests properly updated from approximate to exact assertions. Snapshot hash, monotonicity, and spot-checks all solid. Range hash unchanged. No issues.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The hardcoded J-curve table and real PLOT token address in DeployBase.s.sol look directionally correct, but the PR is still incomplete against issue #536 because it does not include the actual Base redeploy artifact or the recorded new addresses.
Findings
- [high] The repo still records the old StoryFactory deployment and old reserve token, so the ticket's redeploy acceptance criteria are not met.
- File:
broadcast/DeployBase.s.sol/8453/run-latest.json:7 - Suggestion: Commit the new Base mainnet
DeployBasebroadcast output from the redeploy sorun-latest.jsonrecords the new StoryFactory address and constructor args instead of the old0x337c.../0xF8A2...deployment.
- File:
- [medium] The published contract docs still point at the old factory and old PLOT address.
- File:
README.md:27 - Suggestion: Update the Base mainnet contract table and external dependency table so they record the new StoryFactory address and the real PLOT token
0x4F567DACBF9D15A6acBe4A47FC2Ade0719Fb63C4.
- File:
Decision
Requesting changes because issue #536 is explicitly a mainnet redeploy task, and the PR does not yet record that redeploy or publish the resulting addresses anywhere in the repo.
Deployed at: 0x92c3bd44fda84e632c3c3cb31387d0c0c1de618d Tx: 0x1f6635d6fad21d60c7074f81f6931c6dbd3583feeca1ff2b870c31b3aa4861c1 Verified on Sourcify (exact_match) - Update README with new StoryFactory v2 address - Update PLOT token address in README - Mark old StoryFactory as v1 deprecated Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Re-reviewed — deployment artifacts confirmed. New StoryFactory v2 at 0x92c3bd44fda84e632c3c3cb31387d0c0c1de618d with PLOT token 0x4F567DACBF9D15A6acBe4A47FC2Ade0719Fb63C4. Broadcast file updated, README shows v2 + v1 deprecated. APPROVE.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The updated head resolves the redeploy completeness gaps. The repo now records the fresh Base mainnet StoryFactory deployment and publishes the new StoryFactory v2 and real PLOT addresses.
Findings
- No blocking findings.
Decision
Approve. broadcast/DeployBase.s.sol/8453/run-latest.json now records the new StoryFactory deployment at 0x92c3bd44fda84e632c3c3cb31387d0c0c1de618d with the real PLOT token 0x4F567DACBF9D15A6acBe4A47FC2Ade0719Fb63C4, and README.md has been updated accordingly.
Summary
0x4F567DACBF9D15A6acBe4A47FC2Ade0719Fb63C4story-token-curve.txt0.001 → 1.8882421 PLOTacross 500 steps (2,000 token increments)generateCurve()→getCurve()(hardcoded, not generated)DumpCurve.s.soland all test assertions for new curveCurve verification
0x680fad91...2f39e50x2fa88b79...94844Deployment
After merge, deploy with:
Test plan
Fixes realproject7/plotlink#536
🤖 Generated with Claude Code