[#42] Add input validations: title, hash, zero-address, array cap#47
Merged
realproject7 merged 1 commit intomainfrom Mar 20, 2026
Merged
[#42] Add input validations: title, hash, zero-address, array cap#47realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
- chainPlot: require non-empty title - createStoryline/chainPlot: require non-zero content hash - Constructor: require non-zero bond and token addresses - Constructor: cap stepRanges/stepPrices at 1000 entries - Update E2E F4 to use non-empty title (now required) - Add 6 new revert tests for all validation paths All 38 tests pass. Fixes #42 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
T2b Review — APPROVED
All validations correctly placed:
- Constructor: zero address checks before state writes, array cap at 1000
createStoryline: zero hash check after existing title/CID checkschainPlot: empty title + zero hash checks added, matchingcreateStorylinevalidation parity
E2E script F4 updated to use non-empty title since empty titles now revert — correct adaptation.
6 new revert tests cover all added checks. LGTM.
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR adds the requested guardrails without expanding scope: empty-title and empty-hash validation on write paths, zero-address constructor checks, and the constructor step-array cap. The test updates cover each new revert path, and the E2E script adjustment keeps the mainnet flow aligned with the tightened chainPlot() validation.
Findings
- None.
Decision
Approving because the new validations are implemented in the right places, the tests cover them directly, and GitHub checks are passing.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainPlot(): require non-empty title ("Empty title")createStoryline()+chainPlot(): require non-zero content hash ("Empty hash")_bondand_plotTokenaddressesstepRanges/stepPricesat 1000 entries ("Too many steps")Test plan
forge fmt --checkcleanFixes #42
🤖 Generated with Claude Code