[#41] Royalty reduction, remove sunset, struct optimization

[realproject7]

Summary

• Royalty reduction: 500 (5%) → 100 (1%) basis points for both mint and burn
• Remove sunset: deleted bool sunset from Storyline struct; added hasSunset() view that derives from hasDeadline && block.timestamp > lastPlotTime + 168h
• Struct optimization: 5 slots → 2 slots — plotCount uint256→uint24, lastPlotTime uint256→uint40, packed into slot 2 with token and hasDeadline
• Removed require(!s.sunset, "Storyline sunset") from chainPlot() — the existing deadline check covers this
• Updated E2E scripts for 5-field struct destructuring

Test plan

• All 32 tests pass (22 StoryFactory + 10 DeployBase)
• 4 new hasSunset() tests: no deadline, within deadline, expired, reset after chainPlot
• 1 new royaltyConstants() test: asserts MINT_ROYALTY=100, BURN_ROYALTY=100
• forge fmt --check clean

Fixes #41

🤖 Generated with Claude Code

[project7-interns]

T2b Review — APPROVED

Solid contract change. Key checks:

Struct packing — uint24 plotCount (max 16.7M plots) and uint40 lastPlotTime (max year ~36812) are both safe for practical use. Writer (160b) fills slot 1; token (160b) + plotCount (24b) + lastPlotTime (40b) + hasDeadline (8b) = 232 bits in slot 2. Clean packing.

Sunset removal — sunset was never set by contract logic (only via vm.store in tests), so removing it and deriving via hasSunset() view is a safe refactor. The deadline check in chainPlot() already covers the behavior.

Arithmetic safety — uint256(s.lastPlotTime) + 168 hours correctly upcasts before addition. uint40(block.timestamp) is safe for centuries.

Test coverage — 4 hasSunset() tests cover all paths (no deadline, within, expired, reset after chainPlot). Royalty constant test confirms 100bp.

E2E scripts — All struct destructuring correctly updated to 5-field with matching types.

LGTM.

[project7-interns]

Verdict: APPROVE

Summary

The PR implements the three coupled changes from issue #41 together: royalty reduction, sunset removal via derived view logic, and the struct packing update with the corresponding type/destructuring changes. The test updates cover the new hasSunset() behavior and the revised royalty constants, and GitHub checks are passing.

Findings

• None.

Decision

Approving because the change set is internally consistent, follows the issue scope, and the updated tests cover the behavior introduced here.