[#39] Drain pending royalties before D2 revert test#40
Merged
realproject7 merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
The broadcast script's F5 (buy/sell) generates new royalties after D1 claims. When the revert script runs afterward, the deployer has unclaimed royalties, so the D2 empty-claim test passes for the wrong reason. Fix: drain any pending royalties first, then test the revert. Fixes #39 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b review: APPROVED. Correct fix — drains residual royalties from F5 before asserting empty-claim revert. vm.prank(deployer) on both the drain and the test call is correct.
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This change fixes the D2 setup ambiguity by draining any pending royalties in the deployer context before asserting the empty-claim revert. That preserves the intended double-claim semantics after the split-script refactor.
Findings
- None.
Decision
Approving because the PR directly addresses the reported royalty-drain bug and GitHub checks are passing.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #39
🤖 Generated with Claude Code