[#34] Add vm.prank for E8/E9 chainPlot CID validation#35
Merged
realproject7 merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
Group E runs outside vm.broadcast(), so msg.sender is the script
contract. E8/E9 test CID validation in chainPlot but the writer check
fires first ("Not writer") before reaching CID validation. Adding
vm.prank(deployer) ensures the writer check passes so the CID
validation revert is actually tested.
Fixes #34
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b review: APPROVED. Correct fix — vm.prank(deployer) ensures the writer check passes so the CID validation revert is actually exercised.
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This change addresses the actual failure mode in Group E by running E8/E9 under the writer context before asserting the CID-validation revert. The scope is correct and directly matches the reported mainnet behavior.
Findings
- None.
Decision
Approving because the PR fixes the sender-context issue for E8/E9 and GitHub checks are passing.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm.prank(deployer)before E8 and E9chainPlot()callsvm.broadcast(), so msg.sender is the script contract — writer check fires before CID validationTest plan
forge fmt --checkcleanFixes #34
🤖 Generated with Claude Code