Open
Conversation
- Add new Bookshelf tab (position 1) between Bookstore and Audiobook - GRDB-backed persistence with folders and items tables (migration v5) - Grid/list display modes with sort options (manual, recent, title, author) - Folder creation, rename, delete with cascading item cleanup - Batch select, move, and remove operations - Add-to-bookshelf button on BookDetailView action bar - Context menus for move-to-folder and remove actions - Empty state with tutorial tip cards - Deep link support for bookshelf:// URL scheme - Update tab indices: 0=Bookstore, 1=Bookshelf, 2=Audiobook, 3=Me - Localized in 14 languages (en, zh-Hans, zh-Hant, ja, ko, es, fr, de, pt, ru, ar, id, tr, uk)
logan676
force-pushed
the
feature/bookshelf
branch
from
0f53607 to
55576fd
Compare
…, FirebaseAuth guard - Analytics.swift: add custom init(from:) with decodeIfPresent for all numeric fields in 6 Codable structs to prevent keyNotFound crashes - SubscriptionManager.swift: skip retry for 4xx client errors in backend verification to avoid error count inflation - AppDelegate.swift: guard FirebaseApp.app() != nil before Auth.auth() calls to prevent race condition crash on startup
…sync merge - Implement downloadAudiobookTimestamps() to fetch and cache timestamps for offline highlight sync - Auto-trigger timestamp download when audiobook download completes - Clean up timestamps when audiobook is deleted - Replace last-write-wins with field-level merge for reading progress: take max chapter, max scroll position, max progress percent - Add ReadingStatus.merged() to resolve status conflicts by priority (FINISHED > READING > WANT_TO_READ) - Reconcile local state with server response after sync PATCH - Add UserBookDAO.updateProgressWithStatus() for merged updates
…banner - Add bookshelfSync feature gate in FeatureGateService - Add cloud sync push/pull methods in BookshelfManager (Pro only) - Add sync status banner for Pro users (syncing/synced/failed states) - Add upgrade prompt banner for free users with Pro badge and paywall trigger - Add bookshelfSync paywall trigger context with localized strings
Add translations for agora, settings, download, translation sheet, audiobook, categories, and annual report features across all 15 supported languages. Backfill Hindi, German, and Ukrainian with English placeholders (needs_review) for 2115 existing keys.
…/uk languages, backfill translations - Fix hardcoded Chinese "想法" in AgoraPostCard (P0 bug) - Register German (de) and Ukrainian (uk) in knownRegions and AppLanguage - Externalize ~50 hardcoded strings across BookDetailView, TranslationSheet, ImageViewer, AudiobookPlayerView, CategoriesView, MeView, LanguageSettingsView, and all AnnualReport pages - Add 48 new localization keys with translations for all 15 languages - Backfill missing translations for hi/de/uk with English placeholders - Add .id(currentLanguage) to root view for live language switch refresh
- Add Display section with segmented picker for System/Light/Dark appearance mode - Replace hardcoded black overlay with ultraThinMaterial for avatar upload loading state - Add me.section.display localization key for all supported languages
- Add hasBooks guard in BookListStyleDispatcher to skip sections with nil/empty books - Filter out books-less lists when loading from composite cache - Add background refresh after composite cache hit to keep data fresh - Limit concurrent booklist detail requests to 6 to avoid Cloudflare rate limiting - Extract saveCompositeCache() helper that filters invalid entries before saving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New Files (10)
Modified Files (7)
Test plan