Open
Conversation
These cover pre-refactor of HTTP
7f68304 to
47fda4b
Compare
Contributor
Author
|
@mickael-menu any other items you think would be worth addressing here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Change: HTTP Client Refactor
Public API Breaking Changes
stream(request:onReceiveResponse:consume:)now requires theonReceiveResponseparameter.fetch(_:)now returnsHTTPResult<HTTPFetchResponse>instead ofHTTPResult<HTTPResponse>.body: Data?property has been removed. Body data is now accessed viaHTTPFetchResponse.bodyafter a fetch call.isSuccessproperty now returns true only for 2xx status codes (200-299). It previously included 3xx codes (200-399)..errorResponsecase now takes anHTTPFetchResponseinstead of anHTTPResponse.