Skip to content
This repository was archived by the owner on Jan 31, 2026. It is now read-only.

fix(iOS): clearAll(true) method with useWebKit enabled#23

Merged
safaiyeh merged 1 commit intoreact-native-cookies:masterfrom
jacobmllr95:fix-clear-all-webkit
Jan 26, 2020
Merged

fix(iOS): clearAll(true) method with useWebKit enabled#23
safaiyeh merged 1 commit intoreact-native-cookies:masterfrom
jacobmllr95:fix-clear-all-webkit

Conversation

@jacobmllr95
Copy link
Copy Markdown
Contributor

Summary

This PR fixes the clearAll(true) method with the useWebKit option enabled.

All credits go to @mattvick! This is a straight copy of his PR.

Test Plan

What's required for testing (prerequisites)?

An iOS device/simulator and some cookies set for WKHTTPCookieStore.

What are the steps to reproduce (after prerequisites)?

Try to clear WKHTTPCookieStore cookies with the clearAll(true) method.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@safaiyeh safaiyeh self-requested a review January 26, 2020 17:11
@safaiyeh
Copy link
Copy Markdown
Member

Thanks @jackmu95 I appreciate the PR!

@safaiyeh safaiyeh merged commit 68d7620 into react-native-cookies:master Jan 26, 2020
react-native-community-bot pushed a commit that referenced this pull request Jan 26, 2020
## [2.0.1](v2.0.0...v2.0.1) (2020-01-26)

### Bug Fixes

* **iOS:** clearAll(true) correctly clears WebKit cookies ([#23](#23)) ([68d7620](68d7620))
@react-native-community-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jacobmllr95 jacobmllr95 deleted the fix-clear-all-webkit branch January 29, 2020 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants