refactor(proto): regenerate protos after gateway annotations removed#1436
Open
whoAbhishekSah wants to merge 1 commit intomainfrom
Open
refactor(proto): regenerate protos after gateway annotations removed#1436whoAbhishekSah wants to merge 1 commit intomainfrom
whoAbhishekSah wants to merge 1 commit intomainfrom
Conversation
…ns removed) Update PROTON_COMMIT to d93715a (proton PR #444) which removes all openapiv2 and google.api.http annotations from frontier proto files. These annotations were only used by the now-removed gRPC-gateway server. Regenerated proto files are ~4,000 lines smaller as the openapiv2 metadata is no longer embedded in the Go code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Makefile's PROTON_COMMIT variable was updated to reference a different commit hash, changing the Proton version used for downloading protocol buffer definitions during proto generation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
whoAbhishekSah
changed the title
Pull Request Test Coverage Report for Build 22568877003Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROTON_COMMITin Makefile tod93715awhich removes allopenapiv2andgoogle.api.httpannotations from frontier proto filesContext
This PR depends on proton#444 being merged first. Once proton#444 is merged, the
PROTON_COMMITshould be updated to the merge commit SHA on main.Test plan
make protosucceedsgo build ./...passesmake testpasses (all unit tests green)🤖 Generated with Claude Code