Open
Conversation
The Readme suggests that `tokens` can be omitted, but when they are, the request fails. Marketo expects an array for `tokens`. If an empty object is passed, Marketo rejects the request.
Owner
|
According to the docs, you are right. Thank you for opening the PR, could you please also provide tests for it? |
Author
|
It's a 2 character change and there were no tests before. Merging this will improve the codebase slightly 🤷♂ |
Owner
|
You are right, it is a two characters long change. But this was an issue, so to make sure there are no regressions in the future it is a very good practice to write a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Readme suggests that
tokenscan be omitted, but when they are, the request fails.Marketo expects an array for
tokens. If an empty object is passed, Marketo rejects the request.