rpierrorlog: Add rpierrorlog to utils to manage firmware error logging#176
Open
martamomotko wants to merge 1 commit intoraspberrypi:masterfrom
Open
rpierrorlog: Add rpierrorlog to utils to manage firmware error logging#176martamomotko wants to merge 1 commit intoraspberrypi:masterfrom
martamomotko wants to merge 1 commit intoraspberrypi:masterfrom
Conversation
timg236
reviewed
Apr 9, 2026
| @@ -0,0 +1,25 @@ | |||
|
|
|||
| # rpierrorlog | |||
Contributor
There was a problem hiding this comment.
Please can you also update the top level readme with a suitable description
timg236
reviewed
Apr 9, 2026
| LOG_DEBUG("hdr.code=0x%08x tag=0x%08x tag_buf_size=%u tag_req_resp_size=0x%08x\n", | ||
| hdr->code, hdr->tag, hdr->tag_buf_size, hdr->tag_req_resp_size); | ||
|
|
||
| if (!(hdr->code & VC_MAILBOX_ERROR) || |
Contributor
There was a problem hiding this comment.
I've updated rpi-fw-crypto to make this less confusing because bit31 doesn't mean ERROR error. It means tag completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.