Improve FfmpegOutput shutdown if there's an error in the Ffmpeg process#1369
Closed
naushir wants to merge 2 commits intoraspberrypi:nextfrom
Closed
Improve FfmpegOutput shutdown if there's an error in the Ffmpeg process#1369naushir wants to merge 2 commits intoraspberrypi:nextfrom
naushir wants to merge 2 commits intoraspberrypi:nextfrom
Conversation
The sensor has a limit on the min fps that can be set, so will fail this test. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Set a flag to stop us continually re-trying when it's already failed, but leave the tidying up proper to the stop() method. This stops us seeing a few mildly disconcerting errors (unless we want to, of course). Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set a flag to stop us continually re-trying when it's already failed, but leave the tidying up proper to the stop() method. This stops us seeing a few mildly disconcerting errors (unless we want to, of course).