Open
Conversation
The changes allow an IV to be set for the hashing algorithm and reuses the hash of the module name as the IV of the function name. This effetively changes the operation from `hash(mname) + hash(fname)` to `hash(mname + fname)`. Reusing the hash of the module name as the IV instead of adding the result makes the shellcode smaller.
smcintyre-r7
approved these changes
Mar 23, 2026
github-project-automation
bot
moved this from Ready
to In Progress
in Metasploit Kanban
Contributor
|
I've approved this and it's ready to be merged. Doing so however would mean that the next time rapid7/metasploit-framework bumps the gem, the Block API hashing function would be incompatible until rapid7/metasploit-framework#21085 is merged. If rex-text needs changes between now and then, we'd have an issue. Ideally this PR would be merged and bumped when we're ready to land rapid7/metasploit-framework#21085. |
Author
|
@smcintyre-r7 sorry i didn't saw this comment. would it be better if i reopen this targetting 6.5 instead of master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
block api with IV