Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CustomElement 类使用了内部的 onLoad 和 onError 回调函数,这些回调函数仅仅移除了加载元素,但从未向 DOM 分派 load 和 error 事件。所以文档中的load和error事件并未生效
修改内容(components/preview/index.ts:194-199):
composed: true 确保事件能穿透 Shadow DOM 向上冒泡,可以正常监听:
document.querySelector('r-preview').addEventListener('load', (e) => { ... });
document.querySelector('r-preview').addEventListener('error', (e) => { ... });