fix: send explicit protocol error on session race condition (#8)#16
Open
fix: send explicit protocol error on session race condition (#8)#16
Conversation
- When handle_incoming rejects because a session is already active,
send a ProtocolError frame {t:'err', code:'session_active'} to the
initiator instead of silently dropping the connection
- Initiator now checks for protocol errors before parsing ACK and
surfaces a user-friendly message
- Logged rejected connection attempts for visibility
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Send explicit protocol error on session race condition
Closes #8
Problem
When a peer tried to connect to a node that already had an active session,
handle_incomingsilently returnedOk(())without sending any response. The initiator would hang indefinitely waiting for a handshake ACK that never came.Solution
ProtocolErrorwire type ({t: "err", code: "...", msg: "..."})handle_incomingnow sends an error frame withcode: "session_active"before closing the connectioninitiate_session) now checks for protocol errors in the response frame before attempting to parse it as a handshake ACKSecurity considerations
This PR was generated with Oz.