fix: add sequence numbers and sender timestamps for message ordering (#7)#15
Open
fix: add sequence numbers and sender timestamps for message ordering (#7)#15
Conversation
) - Add seq (monotonic sequence number) and ts (sender timestamp) to wire protocol - Track send_seq/recv_seq on ActiveSession for ordering enforcement - Detect out-of-order messages on receive side and log warnings - Use sender timestamp for message display instead of local clock - Sort messages by timestamp in ChatWindow for consistent ordering - Backward compatible: seq/ts fields use serde(default) Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add sequence numbers and sender timestamps for message ordering
Closes #7
Problem
Messages had no explicit ordering mechanism. The ratchet counter was used for decryption only, timestamps were generated locally on receive (subject to clock skew), and the frontend rendered messages in array order without sorting.
Solution
Backend:
seq(monotonic sequence number) andts(sender unix timestamp) fields to the wire message protocolActiveSessionnow trackssend_seqandrecv_seqcountersserde(default)for backward compatibilityFrontend:
ChatWindownow sorts messages bytimestampthen byidfor deterministic orderingSecurity considerations
This PR was generated with Oz.