Address recommendations from Stefan Monnier and others#142
Draft
okamsn wants to merge 1 commit intoradian-software:mainfrom
Draft
Address recommendations from Stefan Monnier and others#142okamsn wants to merge 1 commit intoradian-software:mainfrom
okamsn wants to merge 1 commit intoradian-software:mainfrom
Conversation
raxod502
reviewed
Dec 30, 2022
Member
raxod502
left a comment
raxod502
left a comment
There was a problem hiding this comment.
I'm OK with all these changes. If there's something you'd like me to take a look at to provide historical context or advice, let me know, but as long as the user-facing behavior remains pretty similar to before, it sounds good to me.
okamsn
force-pushed
the
address-recommendations
branch
2 times, most recently
from
aab3ae4 to
99a399f
Compare
These recommendations were made to better support the ELPA method of
fetching and delivering packages (expecting one package per repo)
and of testing builds (not erroring for the optional dependencies of
the now single package).
- Make `require` not signal an error if missing Vertico, Corfu, or
Company.
- Use `featurep` to detect whether requirements are installed.
- Add ELPA-generated files to `gitignore`.
- Improve declarations and add more.
- Mark external packages with "ext" in `declare-function`.
- Remove package requirements from the extension files.
- Add `prescient-pkg.el`.
- Adding the file to the repo (instead of ELPA generating it) seems to
work better for testing.
- Remove version information and package requirements from the
individual extension files.
These two changes allow the command `package-install-from-buffer` in a
Dired buffer to work better. No other changes to the files' preambles
seem needed.
okamsn
force-pushed
the
address-recommendations
branch
from
99a399f to
4e29b4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #138.