Add run-test262 --no-can-block flag#1433
Open
ivankra wants to merge 1 commit intoquickjs-ng:masterfrom
Open
Conversation
The flag is needed to pass the two CanBlockIsFalse tests from test262 when running individual preprocessed tests via run-test262 -N. Fixes quickjs-ng#1431
saghul
approved these changes
Mar 30, 2026
Contributor
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
Don't you need to remove the now non failing tests from the errors txt file?
Author
|
The new flag is primarily for test262_errors.txt is generated in batch mode where it reads it from YAML frontmatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag is needed to pass the two CanBlockIsFalse tests from test262 when running individual preprocessed tests via
run-test262 -N.Fixes #1431