Skip to content

Add support for multiple line comments#6

Merged
jesseporter merged 2 commits intoquic:masterfrom
sbomming-possibly:multiple-single-line-delimiters
Sep 8, 2025
Merged

Add support for multiple line comments#6
jesseporter merged 2 commits intoquic:masterfrom
sbomming-possibly:multiple-single-line-delimiters

Conversation

@sbomming-possibly
Copy link
Copy Markdown
Contributor

Description:

Adds support for multiple delimiters denoting line comments.

@sbomming-possibly sbomming-possibly force-pushed the multiple-single-line-delimiters branch 3 times, most recently from 11fa83e to c192b37 Compare September 5, 2025 19:58
@sbomming-possibly sbomming-possibly force-pushed the multiple-single-line-delimiters branch 2 times, most recently from df7a093 to 276d641 Compare September 8, 2025 20:27
Refactors `Lang` to account for multiple single line comment delimiters.

Signed-off-by: McGuire, Kevin <kmcguire@qti.qualcomm.com>
@sbomming-possibly sbomming-possibly force-pushed the multiple-single-line-delimiters branch from 276d641 to 8c12b2b Compare September 8, 2025 20:32
Copy link
Copy Markdown
Collaborator

@jesseporter jesseporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see inline for one potential enhancement.

Copy link
Copy Markdown
Collaborator

@jesseporter jesseporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sbomming-possibly sbomming-possibly force-pushed the multiple-single-line-delimiters branch from 9595b14 to b28f019 Compare September 8, 2025 20:44
Accept PR feedback

Signed-off-by: Kevin McGuire <kmcguire@qti.qualcomm.com>
@sbomming-possibly sbomming-possibly force-pushed the multiple-single-line-delimiters branch from b28f019 to ef7edb4 Compare September 8, 2025 20:47
@jesseporter jesseporter merged commit 9bd6237 into quic:master Sep 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants