Add MACHINE_NAME evn variable support#320
Open
Srinivas-Kandagatla wants to merge 2 commits intoqualcomm:developmentfrom
Open
Add MACHINE_NAME evn variable support#320Srinivas-Kandagatla wants to merge 2 commits intoqualcomm:developmentfrom
Srinivas-Kandagatla wants to merge 2 commits intoqualcomm:developmentfrom
Conversation
added 2 commits
March 26, 2026 10:48
For some reason it looks like have commited fiels with CRLF fix this by converting them into Unix format. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Add MACHINE_NAME enviroment variable as fallback mechanism to detect machine name, this should allow setups which will not have access to /sys/firmware/ entries, example containers itself to be able to use fastrpc libraries and dynamically get hold of hexagon binary paths. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
ekanshibu
reviewed
Mar 27, 2026
| fclose(file); | ||
| parse_config_dir(machine_name); | ||
| } else { | ||
| char *env_value = getenv("MACHINE_NAME"); |
Contributor
There was a problem hiding this comment.
Changes looks good to me, just 1 basic question. If the plan is to keep containers platform agnostic, how and when will the environment variable get set? Is it expected from the user to set the env before running their use-case?
Author
There was a problem hiding this comment.
Users will be able to deploy containers like this as example, we could do exactly same in docker compose :
docker run -e MACHINE_NAME="$(tr -d '\0' < /sys/firmware/devicetree/base/model)" IMAGE
This is pertty much generic and will work for all the platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MACHINE_NAME enviroment variable as fallback mechanism to detect
machine name, this should allow setups which will not have
access to /sys/firmware/ entries, example containers itself to be able
to use fastrpc libraries and dynamically get hold of hexagon binary
paths.
Apart from this change the file also has some LR chars, this pr converts them before adding the MACHINE_NAME support