apps_mem: fallback to legacy mmap/unmap when internal API fails (Talos)#319
Open
Jianping-Li wants to merge 1 commit intoqualcomm:developmentfrom
Open
apps_mem: fallback to legacy mmap/unmap when internal API fails (Talos)#319Jianping-Li wants to merge 1 commit intoqualcomm:developmentfrom
Jianping-Li wants to merge 1 commit intoqualcomm:developmentfrom
Conversation
Comment on lines
-173
to
-175
| pbuf = (uint64_t)buf; | ||
| *vapps = pbuf; | ||
| minfo->vapps = *vapps; |
Contributor
There was a problem hiding this comment.
Shouldn’t we be storing these addresses?
Contributor
Author
There was a problem hiding this comment.
Thank you for the reminder. I accidentally deleted these three lines because they did not affect the Talos test results, but considering compatibility, they should be added back.
Jianping-Li
force-pushed
the
dsp_err_check
branch
from
4c9acf2 to
bd40857
Compare
On Talos, fastrpc_mmap_internal/munmap_internal can fail or be unsupported. Fallback to fastrpc_mmap and then remote_mmap64_internal, and use remote_munmap64 when internal munmap fails. Signed-off-by: Jianping Li <jianping.li@oss.qualcomm.com>
Jianping-Li
force-pushed
the
dsp_err_check
branch
from
bd40857 to
b66a7f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Talos, fastrpc_mmap_internal/munmap_internal can fail or be unsupported. Fallback to fastrpc_mmap and then remote_mmap64_internal, and use remote_munmap64 when internal munmap fails.