Skip to content

Update tsens thermal zone trip points to 95°C#830

Open
dmantre wants to merge 1 commit intoqualcomm-linux:tech/all/dt/qcs6490from
dmantre:revert-461-for-qcs6490
Open

Update tsens thermal zone trip points to 95°C#830
dmantre wants to merge 1 commit intoqualcomm-linux:tech/all/dt/qcs6490from
dmantre:revert-461-for-qcs6490

Conversation

@dmantre
Copy link

@dmantre dmantre commented Mar 25, 2026

Update trip threshold to 95 as 105 is not applicable for all rb3gen2 boards.

@qcomlnxci qcomlnxci requested a review from a team March 25, 2026 05:44
@dmantre dmantre changed the title Revert "Adjust tsens thermal zone trip thresholds" Update tsens thermal zone trip points to 95°C Mar 25, 2026
Copy link
Collaborator

@shashim-quic shashim-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert "FROMLIST: arm64: dts: qcom: qcs6490-rb3gen2: Adjust tsens thermal zon…"
This reverts commit 776fe08.

Always explain why in commit log.

@dmantre dmantre force-pushed the revert-461-for-qcs6490 branch from a55cfab to fe23c6b Compare March 26, 2026 05:37
@qcomlnxci qcomlnxci requested a review from a team March 26, 2026 05:40
@dmantre dmantre force-pushed the revert-461-for-qcs6490 branch from fe23c6b to 9f34e0a Compare March 26, 2026 06:27
@dmantre
Copy link
Author

dmantre commented Mar 26, 2026

Updated the commit log.

@dmantre dmantre force-pushed the revert-461-for-qcs6490 branch 2 times, most recently from f764c7f to fbbb9b5 Compare March 26, 2026 07:07
@gauravkohli1
Copy link

LGTM

@dmantre dmantre requested a review from shashim-quic March 26, 2026 07:12
@dmantre dmantre force-pushed the revert-461-for-qcs6490 branch from fbbb9b5 to 2a7284b Compare March 26, 2026 07:29
Copy link
Collaborator

@shashim-quic shashim-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check checker reported error

WARNING: From:/Signed-off-by: email name mismatch: 'From: gauravkohli1 <gaurav.kohli@oss.qualcomm.com>' != 'Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>'

@shashim-quic
Copy link
Collaborator

please check checker reported error

WARNING: From:/Signed-off-by: email name mismatch: 'From: gauravkohli1 <gaurav.kohli@oss.qualcomm.com>' != 'Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>'
commit 2a7284bb0b892ea1fcb759199cbe74e077d31e18
Author:     gauravkohli1 <gaurav.kohli@oss.qualcomm.com>
AuthorDate: Wed Mar 25 11:09:34 2026 +0530
Commit:     Dipa Ramesh Mantre <dmantre@qti.qualcomm.com>
CommitDate: Thu Mar 26 12:58:33 2026 +0530

    Revert "arm64: dts: qcom: qcs6490-rb3gen2: Adjust tsens thermal zone"

    This reverts commit 776fe08770380b70f8ec3d7a8878bf1846a106cb.

    Update trip threshold back to 95 degree as 105 is not applicable for
    all rb3gen2 boards. So reverting this change.

    Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
    Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>

This reverts commit 776fe08.

Update trip threshold back to 95 degree as 105 is not applicable for
all rb3gen2 boards. So reverting this change.

Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>
@dmantre dmantre force-pushed the revert-461-for-qcs6490 branch from 2a7284b to 87f6c57 Compare March 26, 2026 12:24
@qcomlnxci qcomlnxci requested a review from a team March 26, 2026 12:27
@dmantre
Copy link
Author

dmantre commented Mar 26, 2026

Corrected email-id

@dmantre dmantre requested a review from shashim-quic March 26, 2026 13:16
@gauravkohli1
Copy link

please check checker reported error

WARNING: From:/Signed-off-by: email name mismatch: 'From: gauravkohli1 <gaurav.kohli@oss.qualcomm.com>' != 'Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>'
commit 2a7284bb0b892ea1fcb759199cbe74e077d31e18
Author:     gauravkohli1 <gaurav.kohli@oss.qualcomm.com>
AuthorDate: Wed Mar 25 11:09:34 2026 +0530
Commit:     Dipa Ramesh Mantre <dmantre@qti.qualcomm.com>
CommitDate: Thu Mar 26 12:58:33 2026 +0530

    Revert "arm64: dts: qcom: qcs6490-rb3gen2: Adjust tsens thermal zone"

    This reverts commit 776fe08770380b70f8ec3d7a8878bf1846a106cb.

    Update trip threshold back to 95 degree as 105 is not applicable for
    all rb3gen2 boards. So reverting this change.

    Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
    Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>

HI Shiraz,

I think problem here is Dipa reverted the pr directly, so it is showing below error
WARNING: From:/Signed-off-by: email name mismatch:

For fix i think we can add sign off by github id or close this pr and revert change and then create new pr.
Can you please suggest the right way.

@gauravkohli1
Copy link

please check checker reported error

WARNING: From:/Signed-off-by: email name mismatch: 'From: gauravkohli1 <gaurav.kohli@oss.qualcomm.com>' != 'Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>'
commit 2a7284bb0b892ea1fcb759199cbe74e077d31e18
Author:     gauravkohli1 <gaurav.kohli@oss.qualcomm.com>
AuthorDate: Wed Mar 25 11:09:34 2026 +0530
Commit:     Dipa Ramesh Mantre <dmantre@qti.qualcomm.com>
CommitDate: Thu Mar 26 12:58:33 2026 +0530

    Revert "arm64: dts: qcom: qcs6490-rb3gen2: Adjust tsens thermal zone"

    This reverts commit 776fe08770380b70f8ec3d7a8878bf1846a106cb.

    Update trip threshold back to 95 degree as 105 is not applicable for
    all rb3gen2 boards. So reverting this change.

    Signed-off-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
    Signed-off-by: Dipa Ramesh Mantre <dipa.mantre@oss.qualcomm.com>

HI Shiraz,

I think problem here is Dipa reverted the pr directly, so it is showing below error WARNING: From:/Signed-off-by: email name mismatch:

For fix i think we can add sign off by github id or close this pr and revert change and then create new pr. Can you please suggest the right way.

looks like now no email checker issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants