Only upload docker images from schedule or merged PR#15
Draft
bwarden wants to merge 3 commits intoqualcomm-linux:mainfrom
Draft
Only upload docker images from schedule or merged PR#15bwarden wants to merge 3 commits intoqualcomm-linux:mainfrom
bwarden wants to merge 3 commits intoqualcomm-linux:mainfrom
Conversation
Do not upload docker images created by PRs *until* they've been merged. Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
abickett
reviewed
Mar 27, 2026
| with: | ||
| arch: arm64 | ||
|
|
||
| - name: Build and Upload Images |
Contributor
There was a problem hiding this comment.
Change name to "Upload Images" ?
Signed-off-by: Brett T. Warden <bwarden@qti.qualcomm.com>
keerthi-go
approved these changes
Mar 27, 2026
bwarden
commented
Mar 27, 2026
| - name: Upload Images | ||
| uses: ./.github/actions/upload_containers | ||
| # Only upload if the PR is being merged | ||
| if: ${{ github.event_name == 'schedule' || (github.event_name == 'pull_request' && github.event.action == 'closed' && github.event.pull_request.merged == true) }} |
Author
There was a problem hiding this comment.
I'm not completely certain this logic is correct. At least for now, this PR doesn't trigger the upload, but I'd appreciate a careful review by someone more familiar with workflows and the difference between pull_request and pull_request_target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not upload docker images created by PRs until they've been merged.