Made qmk-dfu wait for exit key to be released before exiting bootloader#9
Open
Duckle29 wants to merge 1 commit intoqmk:masterfrom
Open
Made qmk-dfu wait for exit key to be released before exiting bootloader#9Duckle29 wants to merge 1 commit intoqmk:masterfrom
Duckle29 wants to merge 1 commit intoqmk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change waits for the user to let go of the bootloader escape key. This is to avoid the key triggering bootmagic if enabled and using the same key, as described in qmk/qmk_firmware#8302