Conversation
neoformit
left a comment
neoformit
left a comment
There was a problem hiding this comment.
Since you're getting near the end of your internship, can I please ask you to add a README.md file in test/selenium that briefly explains how to run and maintain (add new reports) the tests?
Also, need to add pyyaml to requirements.
And please make sure the tests runs and passes before opening the a PR!
|
|
||
|
|
||
| reports = parse_csv(Path("assertions.csv")) | ||
| reports = [parse_yaml(f) for f in sorted(Path(".").glob("*.yaml"))] |
There was a problem hiding this comment.
Just to keep things clean, would you mind please moving them into a subfolder "expected"? Looks like you already expect these in a "reports" folder (which also makes sense) but have not actually moved the YAML files there yet, so I get a test failure where exists = PosixPath('reports/1_report_SME25-218_2025-12-11_07_30_03.html').exists.
| component.match_accession.assert_value(table_data["match_accession"]) | ||
| component.match_identity.assert_value(table_data["match_identity"]) | ||
| def assert_toi_table(toi_tab, toi_table, table_data): | ||
| toi_tab.toi_number_of_rows.assert_value(table_data["row_count"]) |
There was a problem hiding this comment.
Docstring here would be good - try to think about the non-obvious things? Like "expected values are in a list with one value for each row in the table".
2 participants
Description