Removed the redundant tooltip on hovering over a holiday#79
Open
balajis-qb wants to merge 3 commits intomainfrom
Open
Removed the redundant tooltip on hovering over a holiday#79balajis-qb wants to merge 3 commits intomainfrom
balajis-qb wants to merge 3 commits intomainfrom
Conversation
- Removed holiday from title. - Retained holiday tooltip only in the hover tooltip. - Updated tests to reflect changes in title to tooltip text for better clarity. Closes Hacker0x01#6260
- Updated the bottom position of the overlay to ensure proper alignment.
…ar dynamically - Changed the initialization of selectedDate to use the current date. - Updated holiday dates to reflect the current year instead of hardcoded values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: Hacker0x01#6260
Problem
As I mentioned in the ticket, we're getting a redundant tooltip on hovering over a holiday. The reason is because we have added the same tooltip on the title and also added as a tooltip overlay. As a fix, I removed it from the holiday names from the
titleattribute.Changes
Screenshots
Contribution checklist