[protobuf] Bump to 7.34.1 and improve type coverage#15569
Open
emmanuel-ferdman wants to merge 2 commits intopython:mainfrom
Open
[protobuf] Bump to 7.34.1 and improve type coverage#15569emmanuel-ferdman wants to merge 2 commits intopython:mainfrom
emmanuel-ferdman wants to merge 2 commits intopython:mainfrom
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: spark (https://github.com/apache/spark)
+ python/pyspark/sql/connect/client/core.py:1147: error: "FieldDescriptor" has no attribute "label" [attr-defined]
+ python/pyspark/sql/connect/client/core.py:1158: error: "FieldDescriptor" has no attribute "label" [attr-defined]
+ python/pyspark/sql/connect/client/core.py:1165: error: "FieldDescriptor" has no attribute "label" [attr-defined]
|
srittau
reviewed
Mar 30, 2026
Comment on lines
+23
to
+43
| enum_types: Any | ||
| enum_types_by_name: Any | ||
| enum_values_by_name: Any | ||
| extension_ranges: Any | ||
| extensions: Any | ||
| extensions_by_name: Any | ||
| fields: Any | ||
| fields_by_camelcase_name: Any | ||
| fields_by_name: Any | ||
| fields_by_number: Any | ||
| file: FileDescriptor | ||
| full_name: str | ||
| has_options: bool | ||
| is_extendable: bool | ||
| name: str | ||
| nested_types: Any | ||
| nested_types_by_name: Any | ||
| oneofs: Any | ||
| oneofs_by_name: Any | ||
| def __new__(cls, *args, **kwargs) -> Self: ... | ||
| def CopyToProto(self, proto: Any, /) -> None: ... |
Collaborator
There was a problem hiding this comment.
I noticed that you replaced Incomplete with Any annotations are added Any to previously unannotated items. Why? Also please note that we need a comment for each Any explaining the possible types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Bump protobuf stubs from 6.32.1 to 7.34.1 - removes deprecated
label/float_format/float_precisionparams, adds new methods, replaces allIncompletewith precise types, adds missing module stubs and narrowsAnyto specific types.Closes #14887