[3.10] gh-143930: Reject leading dashes in webbrowser URLs (GH-143931)#146359
Merged
ambv merged 1 commit intopython:3.10from Mar 24, 2026
Merged
[3.10] gh-143930: Reject leading dashes in webbrowser URLs (GH-143931)#146359ambv merged 1 commit intopython:3.10from
ambv merged 1 commit intopython:3.10from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR backports a security hardening change to webbrowser to prevent option-injection style issues by rejecting URLs that begin with - (after leading whitespace) before passing them to browser launchers.
Changes:
- Add
BaseBrowser._check_url()to reject leading-dash URLs with aValueError. - Invoke
_check_url()from multipleopen()implementations that launch browsers. - Add a regression test and a Security NEWS blurb.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Misc/NEWS.d/next/Security/2026-01-16-12-04-49.gh-issue-143930.zYC5x3.rst |
Documents the security behavior change in webbrowser.open(). |
Lib/webbrowser.py |
Introduces URL validation and applies it to several browser controllers. |
Lib/test/test_webbrowser.py |
Adds a test ensuring leading-dash inputs are rejected (currently for GenericBrowser). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
(cherry picked from commit 82a24a4) Co-authored-by: Seth Michael Larson <seth@python.org>
tomcruiseqi
force-pushed
the
backport-82a24a4-3.10
branch
from
69fd15b to
c84b32d
Compare
tomcruiseqi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 82a24a4)