Merged
Conversation
mblayman
requested changes
Jul 12, 2025
Member
mblayman
left a comment
mblayman
left a comment
There was a problem hiding this comment.
Thanks for the contribution. This looks pretty good. I've got some minor changes. Also, it looks like CI is failing. Can you confirm that the failure is not coming from your change?
Contributor
Author
|
For the failing CI I don't know. It seems to be intergration tests which fails, but not because of a failing test, but a failing import |
Unknown tap line where simply discarded. Instead, provide a way to retrieve the original text programmatically. This could be used by an alternative CLI application to pass through those lines. Signed-off-by: Pierrick Guillaume <pguillaume@fymyte.com>
Fymyte
force-pushed
the
fymyte/unknown-text
branch
from
28e0b3e to
1da8c04
Compare
Contributor
Author
|
I Just tested with current main, integration tests are still failing |
Contributor
Author
|
Probably an updated pytest or tox, which does something unexpected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unknown tap line where simply discarded. Instead, provide a way to retrieve the original text programmatically. This could be used by an alternative CLI application to pass through those lines.
To accept your contribution, please ensure that the checklist below is complete.