removed toolz, potential bugfixes, perfomance improvements, and more#43
Open
jorenham wants to merge 24 commits intopythological:mainfrom
Open
removed toolz, potential bugfixes, perfomance improvements, and more#43jorenham wants to merge 24 commits intopythological:mainfrom
toolz, potential bugfixes, perfomance improvements, and more#43jorenham wants to merge 24 commits intopythological:mainfrom
Conversation
Member
|
Thanks for the contribution! I'm pretty busy right now, so I might not get a chance to review this in the next few days, but the changes sound great, so I definitely do want to review it sooner than later. |
Author
|
@brandonwillard Except for a few (reasonable) exceptions, each commit is limited to the changes of one function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this repo was being used by some big performance-focused projects (e.g. pymc), so I figured I'd take a look at the code. So, apparantly, this is the result of me "looking" at the code 🤷🏻♂️ :
toolz, by rewritingmatch.orderingusing a (faster) dict comprehensionutil._toposortvariable.Varinstance check==comparison oftype'score.assocutils.freezeutil.transitive_gettry:blocks... and I'm sure I'm forgetting some stuff 😅