PR: Fix extension install path not changeable (#3193)#3198
Open
PR: Fix extension install path not changeable (#3193)#3198
Conversation
Added functions to ensure custom extension paths are registered and to get the default extension directory. Updated the custom section for extension installation to handle new paths and states.
Contributor
|
Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔 |
Refactor get_thirdparty_ext_root_dirs to use a list for deterministic ordering and to ensure the default path is first when included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functions to ensure custom extension paths are registered and to get the default extension directory. Updated the custom section for extension installation to handle new paths and states.
PR: Fix extension install path not changeable (#3193)
Fixes #3193 — The Extension Manager's "Pick installation path" button was grayed out when selecting a catalog extension to install, and the auto-selected default path was non-deterministic. Additionally, picking a custom folder that wasn't already in the user's Custom Extension Directories would silently fail after reload because the folder was never registered as a search path.ct.
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
Root Cause
The Feb 15 UI refactoring (commit ec2eb76) replaced the old context-menu dropdown install flow with a text field + "Pick" button, but introduced three bugs:
_update_add_custom_section_for_selection() unconditionally setpath_custom_ext_b.IsEnabled = False, locking out path selection for uninstalled extensionsget_thirdparty_ext_root_dirs()collected paths in a Pythonset(), making[0]non-deterministic — users got their server path instead of the local defaultinstall_custom_extension()never registered the chosen install directory in pyRevit's config, so extensions installed to new folders weren't discovered after reloadAdditional Notes
Include any additional context, screenshots, or considerations for reviewers.
Thank you for contributing to pyRevit! 🎉