Skip to content

PR: Fix extension install path not changeable (#3193)#3198

Open
tay0thman wants to merge 2 commits intodevelopfrom
tay0thman-fix_custom_extensions-1
Open

PR: Fix extension install path not changeable (#3193)#3198
tay0thman wants to merge 2 commits intodevelopfrom
tay0thman-fix_custom_extensions-1

Conversation

@tay0thman
Copy link
Copy Markdown
Contributor

Added functions to ensure custom extension paths are registered and to get the default extension directory. Updated the custom section for extension installation to handle new paths and states.

PR: Fix extension install path not changeable (#3193)

Fixes #3193 — The Extension Manager's "Pick installation path" button was grayed out when selecting a catalog extension to install, and the auto-selected default path was non-deterministic. Additionally, picking a custom folder that wasn't already in the user's Custom Extension Directories would silently fail after reload because the folder was never registered as a search path.ct.


Checklist

Before submitting your pull request, ensure the following requirements are met:

  • [ ok] Code follows the PEP 8 style guide.
  • [ ok] Code has been formatted with Black using the command:
    pipenv run black {source_file_or_directory}
  • [ ok] Changes are tested and verified to work as expected.

Related Issues

Root Cause

The Feb 15 UI refactoring (commit ec2eb76) replaced the old context-menu dropdown install flow with a text field + "Pick" button, but introduced three bugs: _update_add_custom_section_for_selection() unconditionally set path_custom_ext_b.IsEnabled = False, locking out path selection for uninstalled extensions
get_thirdparty_ext_root_dirs() collected paths in a Python set(), making [0] non-deterministic — users got their server path instead of the local default
install_custom_extension() never registered the chosen install directory in pyRevit's config, so extensions installed to new folders weren't discovered after reload

Additional Notes

Include any additional context, screenshots, or considerations for reviewers.


Thank you for contributing to pyRevit! 🎉

Added functions to ensure custom extension paths are registered and to get the default extension directory. Updated the custom section for extension installation to handle new paths and states.
@devloai
Copy link
Copy Markdown
Contributor

devloai bot commented Mar 27, 2026

Unable to trigger custom agent "Code Reviewer". You have run out of credits 😔
Please upgrade your plan or buy additional credits from the subscription page.

Refactor get_thirdparty_ext_root_dirs to use a list for deterministic ordering and to ensure the default path is first when included.
@tay0thman tay0thman requested a review from jmcouffin March 27, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Install Extensions Path not changeable

1 participant