fix: Update public export declarations from __init__.py files#1580
fix: Update public export declarations from __init__.py files#1580kylebarron wants to merge 2 commits intopyproj4:mainfrom
__init__.py files#1580Conversation
| "CoordinateOperation", | ||
| "CoordinateSystem", | ||
| "CustomConstructorCRS", | ||
| "Datum", | ||
| "DerivedGeographicCRS", | ||
| "Ellipsoid", | ||
| "GeocentricCRS", | ||
| "GeographicCRS", | ||
| "PrimeMeridian", |
There was a problem hiding this comment.
All of these newly-added exports were already in the public docs for pyproj.crs
| class. | ||
| """ | ||
|
|
||
| from pyproj._crs import ( # noqa: F401 pylint: disable=unused-import |
There was a problem hiding this comment.
We don't need the noqa when all imports are used in __all__
| "get_ellps_map", | ||
| "get_prime_meridians_map", | ||
| "get_proj_operations_map", | ||
| "get_units_map", |
There was a problem hiding this comment.
This was deprecated as exported from the top-level and is suggested to import from pyproj.database https://pyproj4.github.io/pyproj/stable/api/database.html#pyproj.database.get_units_map
| from pyproj.list import ( # noqa: F401 pylint: disable=unused-import | ||
| get_ellps_map, | ||
| get_prime_meridians_map, | ||
| get_proj_operations_map, | ||
| ) | ||
| from pyproj.proj import Proj, pj_list # noqa: F401 pylint: disable=unused-import | ||
| from pyproj.transformer import ( # noqa: F401 pylint: disable=unused-import | ||
| Transformer, | ||
| itransform, | ||
| transform, | ||
| ) |
There was a problem hiding this comment.
This diff is just removing the unnecessary noqa: F401 because all imports are used
What about |
|
No, that still errors 
In any case, the documentation for |
|
FWIW the pylance link goes to https://github.com/microsoft/pylance-release/blob/main/docs/diagnostics/reportPrivateImportUsage.md |
2 participants
When I try to import
CoordinateOperation, pylance gives me an error, because it wasn't included in__all__history.rstfor all changes andapi/*.rstfor new API