Fix get method in models.py to not throw an exception when returning an empty item. by domderen · Pull Request #1289 · pynamodb/PynamoDB

domderen · 2025-09-16T08:44:04Z

Fix for issue #1287 (comment) When getting a model value with attributes_to_get parameter, set in a way where it could return an empty object, the get method is erronously throwing an exception even though the object exists. This fixes the issue.

…an empty item. Fix for issue pynamodb#1287 (comment) When getting a model value with `attributes_to_get` parameter, set in a way where it could return an empty object, the get method is erronously throwing an exception even though the object exists. This fixes the issue.

ikonst · 2025-09-16T11:30:39Z

pynamodb/models.py

-            item_data = data.get(ITEM)
-            if item_data:
-                return cls.from_raw_data(item_data)
+            if ITEM in data:


probably if data and ITEM in data:

ikonst · 2025-09-16T11:31:02Z

Are you going to add a test?

…w behavior.

domderen · 2025-09-16T21:19:11Z

Hey, let me know whatt you think :)

tests/test_model.py

domderen · 2025-09-18T07:27:05Z

Hey, I updated the comments, and I removed the second test as indeed there were other places that already check if this exception is thrown when Item is not in the response.

In regards to better asserts, I'm now checking if the property we are trying to get indeed does not exist, even though the object is of correct type. Is this something more in line with your thinking?

domderen · 2025-10-09T19:52:28Z

Hey, any update on that?

domderen mentioned this pull request Sep 16, 2025

PynamoDB's Model.get operation throws an incorrect exception when getting an object with only single optional attribute_to_get #1287

Open